Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Client improvements #125

Closed
wants to merge 2 commits into from
Closed

Client improvements #125

wants to merge 2 commits into from
+256 −87

Conversation

vietj
Copy link
Contributor

@vietj vietj commented Mar 25, 2019

see #124
see #123

@vietj vietj requested a review from ppatierno March 25, 2019 12:17
@vietj vietj force-pushed the client-improvements branch from 1461d40 to a0edb48 Compare March 26, 2019 09:14
@vietj vietj force-pushed the client-improvements branch from a0edb48 to e711a4e Compare March 26, 2019 10:01
ppatierno
ppatierno reviewed Mar 26, 2019
View reviewed changes
Copy link
Member

@ppatierno ppatierno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While talking about the PING on the related issue, I would love to have a different PR for the refactoring around headers because I think it's really useful. Having that inside this PR makes this one too bigger than needed.

@vietj vietj closed this Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppatierno ppatierno ppatierno left review comments

Assignees
No one assigned
Labels
to review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vietj @ppatierno @pmlopes